chore(docs): bumped framework and added switchers#299
chore(docs): bumped framework and added switchers#299jeff-phillips-18 merged 6 commits intopatternfly:mainfrom
Conversation
thatblindgeye
force-pushed
the
docsBumpSwitchers
branch
2 times, most recently
from
e254401 to
58b52e7
Compare
thatblindgeye
force-pushed
the
docsBumpSwitchers
branch
from
f7cc45e to
7eb9d96
Compare
There was a problem hiding this comment.
This is looking great @thatblindgeye - thanks for helping keep our versions up to date and for adding the switchers. The theming switcher looks great and works as expected - just seeing some issues when RTL switcher is enabled.
PF Topology will require additional updates to fully support RTL with our current implementation, so it may be best to disable the RTL switcher in the meantime - WDYT @thatblindgeye @jeff-phillips-18 ?
| port: 8008, | ||
| hasThemeSwitcher: true, | ||
| hasHighContrastSwitcher: true, | ||
| hasRTLSwitcher: true |
There was a problem hiding this comment.
| hasRTLSwitcher: true |
Agreed, it would take some work for topology to support RTL for the nodes |
|
Yeah the RTL switcher isn't necessary now then, and it's an ezpz enough addition once that work does commence. @jenny-s51 removed that from the docs build |
jenny-s51
left a comment
jenny-s51
left a comment
There was a problem hiding this comment.
Thank you @thatblindgeye - LGTM!
|
🎉 This PR is included in version 6.5.0-prerelease.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
5 participants
What
Closes #
Description
Type of change
Screen shots / Gifs for design review